Skip to content

fix(Collapse): show Icon and Text both #6536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 3, 2025
Merged

fix(Collapse): show Icon and Text both #6536

merged 2 commits into from
Aug 3, 2025

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Aug 3, 2025 •
edited
Loading

Link issues

fixes #6535
fixes #6466

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Bug Fixes:

  • Show both icon and text in Collapse item headers instead of choosing one or the other

@bb-auto bb-auto bot added the bug Something isn't working label Aug 3, 2025
@bb-auto bb-auto bot added this to the 9.9.0 milestone Aug 3, 2025
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Aug 3, 2025 •
edited
Loading

Reviewer's Guide

Updated Collapse component’s rendering logic to display both icon and text when both are provided, instead of choosing one over the other.

Class diagram for updated Collapse item rendering

classDiagram
    class CollapseItem {
        +string Icon
        +string Text
        +RenderFragment HeaderTemplate
    }
    class Collapse {
        +List<CollapseItem> Items
        +string GetItemIconString(CollapseItem item)
    }
    Collapse "1" o-- "*" CollapseItem : contains
Loading

File-Level Changes

Change Details Files
Render both icon and text when present in Collapse items
  • Removed exclusive else-if branch for icon-only rendering
  • Added a conditional block to render the icon when item.Icon is non-empty
  • Added a separate conditional block to render the text when item.Text is non-empty
 src/BootstrapBlazor/Components/Collapse/Collapse.razor

Assessment against linked issues

Issue Objective Addressed Explanation
#6535 Update the Collapse component so that both Icon and Text are shown together when both are provided. ✅

Possibly linked issues

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai bot approved these changes Aug 3, 2025
View reviewed changes
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ArgoZhang ArgoZhang merged commit 184b491 into main Aug 3, 2025
5 checks passed
@ArgoZhang ArgoZhang deleted the feat-collapse branch August 3, 2025 02:19
@codecov
Copy link

codecov bot commented Aug 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (e12f5cd) to head (1d2cf9e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main     #6536   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          714       714           
  Lines        31392     31395    +3     
  Branches      4431      4432    +1     
=========================================
+ Hits         31392     31395    +3
Flag Coverage Δ
BB 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This was referenced Aug 5, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] approved these changes

Assignees

@ArgoZhang ArgoZhang

Labels

bug Something isn't working

Projects

None yet

Milestone

v9.9.0

Development

Successfully merging this pull request may close these issues.

bug(Collapse): show Icon and Text both feat(Collapse): redesign HeaderTemplate function

2 participants

@ArgoZhang